Allow specifying deprecation level for REST deprecation handler#80629
Merged
dakrone merged 4 commits intoelastic:masterfrom Nov 16, 2021
Merged
Conversation
This allows specifying an optional level to be used for the deprecation handler registering a route. Relates to elastic#80167
Contributor
|
FWIW, Kibana originally used default |
pgomulka
approved these changes
Nov 16, 2021
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
LGTM
I left one comment
| public void handleRequest(RestRequest request, RestChannel channel, NodeClient client) throws Exception { | ||
| if (compatibleVersionWarning == false) { | ||
| deprecationLogger.warn(DeprecationCategory.API, deprecationKey, deprecationMessage); | ||
| if (deprecationLevel == null || deprecationLevel == Level.WARN) { |
Contributor
There was a problem hiding this comment.
i was going to comment about this having a default value. But I see that a default level is different for compatible and different for "current version" deprecations.
might be worth a comment why deprecationLevel is nullable and why there is a different behaviour?
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 16, 2021
…tic#80629) This allows specifying an optional level to be used for the deprecation handler registering a route. The default remains if the level is unspecified. Relates to elastic#80167
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Nov 16, 2021
…tic#80629) This allows specifying an optional level to be used for the deprecation handler registering a route. The default remains if the level is unspecified. Relates to elastic#80167 # Conflicts: # server/src/main/java/org/elasticsearch/common/logging/DeprecationLogger.java # server/src/main/java/org/elasticsearch/rest/DeprecationRestHandler.java # server/src/main/java/org/elasticsearch/rest/RestController.java # server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestPutIndexTemplateAction.java # server/src/test/java/org/elasticsearch/rest/DeprecationRestHandlerTests.java # server/src/test/java/org/elasticsearch/rest/RestControllerTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 16, 2021
…) (#80779) This allows specifying an optional level to be used for the deprecation handler registering a route. The default remains if the level is unspecified. Relates to #80167 # Conflicts: # server/src/main/java/org/elasticsearch/common/logging/DeprecationLogger.java # server/src/main/java/org/elasticsearch/rest/DeprecationRestHandler.java # server/src/main/java/org/elasticsearch/rest/RestController.java # server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestPutIndexTemplateAction.java # server/src/test/java/org/elasticsearch/rest/DeprecationRestHandlerTests.java # server/src/test/java/org/elasticsearch/rest/RestControllerTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specifying an optional level to be used for the deprecation handler registering a route.
The default remains if the level is unspecified.
Relates to #80167