Fix HiddenField checkstyle problems in client/#80549
Merged
pugnascotia merged 1 commit intoelastic:masterfrom Nov 10, 2021
Merged
Fix HiddenField checkstyle problems in client/#80549pugnascotia merged 1 commit intoelastic:masterfrom
pugnascotia merged 1 commit intoelastic:masterfrom
Conversation
Fix a number of cases of shadows vars under client/rest-high-level. As part of this, fork the Checkstyle HiddeFieldCheck class so that it understand the pattern of settings with no "set" prefix.
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
added a commit
that referenced
this pull request
Nov 10, 2021
Part of #19752. Fix a number of cases of shadows vars under `client/rest-high-level`. As part of this, fork the Checkstyle `HiddeFieldCheck` class so that it understand the pattern of settings with no "set" prefix.
Contributor
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19752.
Fix a number of cases of shadows vars under
client/rest-high-level. Aspart of this, fork the Checkstyle
HiddeFieldCheckclass so that itunderstand the pattern of settings with no "set" prefix.