Fix "outer" max_docs documentation#80436
Merged
jakelandis merged 1 commit intoelastic:masterfrom Nov 8, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
debadair
approved these changes
Nov 6, 2021
Contributor
debadair
left a comment
There was a problem hiding this comment.
LGTM. Our policy is to backport to the actively-maintained branches. With the auto-backport tool, if we can backport to additional branches, that's a bonus. (When it works, great, if it doesn't we should fall back to the usual maintenance policy.)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
This was referenced Nov 8, 2021
Collaborator
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a documentation bug that lists 'max_docs'
nested under
sourceit should live at the same level assourcerelated: #43373
Note - I have set auto-back port to all branches that this will apply cleanly. It looks like the change could be applied back to 7.3, but anything prior to 7.13 I don't think will merge cleanly without manual intervention.
Preview: https://elasticsearch_80436.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/docs-reindex.html#docs-reindex-api-request-body