Scriptfield test: set number of shards to 1#80026
Merged
stu-elastic merged 1 commit intoelastic:masterfrom Oct 28, 2021
Merged
Conversation
The 20_scriptfield:"Scripted Field with error accessing an unsupported field via the script fields api" test expects to fail because the field is not yet supported in the fields API. However, if the number of shards in the target index is randomly more than one, the empty shard will succeed leading to a 200 response rather than the expected 400 response. This change forces the number of shards to 1 to avoid this scenario. Fixes: elastic#79986
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Oct 28, 2021
The 20_scriptfield:"Scripted Field with error accessing an unsupported field via the script fields api" test expects to fail because the field is not yet supported in the fields API. However, if the number of shards in the target index is randomly more than one, the empty shard will succeed leading to a 200 response rather than the expected 400 response. This change forces the number of shards to 1 to avoid this scenario. Fixes: elastic#79986 Backport: 9511c54
stu-elastic
added a commit
that referenced
this pull request
Oct 28, 2021
The 20_scriptfield:"Scripted Field with error accessing an unsupported field via the script fields api" test expects to fail because the field is not yet supported in the fields API. However, if the number of shards in the target index is randomly more than one, the empty shard will succeed leading to a 200 response rather than the expected 400 response. This change forces the number of shards to 1 to avoid this scenario. Fixes: #79986 Backport: 9511c54
Contributor
Author
|
master (v8.1): 9511c54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
20_scriptfield:"Scripted Field with error accessing anunsupported field via the script fields api" test expects to fail because
the field is not yet supported in the fields API.
However, if the number of shards in the target index is randomly more
than one, the empty shard will succeed leading to a 200 response rather
than the expected 400 response.
This change forces the number of shards to 1 to avoid this scenario.
Fixes: #79986