Check whether stdout is a real console#79882
Merged
tvernum merged 4 commits intoelastic:masterfrom Oct 28, 2021
Merged
Conversation
Adds a new "ConsoleLoader" that uses jANSI in a separate classloader to determine whether standard output is a real console (that is, not redirected to a file or /dev/null, etc)
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
@rjernst I think this roughly what you had in mind in your comments here #79740 (review) This implementation is a little rough (I'm not sure |
jkakavas
approved these changes
Oct 27, 2021
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
LGTM, I verified the intended behavior manually too
rjernst
approved these changes
Oct 27, 2021
| public static void init(PrintStream originalStandardOut) { | ||
| BootstrapInfo.originalStandardOut = originalStandardOut; | ||
| public static void init() { | ||
| BootstrapInfo.consoleOutput = new SetOnce<>(); |
Member
There was a problem hiding this comment.
I would just construct the SetOnce at the declaration of consoleOutput. Then it can be final.
Contributor
Author
There was a problem hiding this comment.
Thanks.
I'm not sure how I ended leaving it like that - a rush to prove the prototype, I guess.
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Oct 28, 2021
Adds a new "ConsoleLoader" that uses jANSI in a separate classloader to determine whether standard output is a real console (that is, not redirected to a file or /dev/null, etc) Also updates security auto-configuration to only print out credentials when there is a console. Backport of: elastic#79882
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2021
Adds a new "ConsoleLoader" that uses jANSI in a separate classloader to determine whether standard output is a real console (that is, not redirected to a file or /dev/null, etc) Also updates security auto-configuration to only print out credentials when there is a console. Backport of: #79882 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 28, 2021
…formance * upstream/master: (153 commits) [ML] update truncation default & adding field output when input is truncated (elastic#79942) [ML] stop using isAllowedByLicense for model license checks (elastic#79908) [ML] Retain built-in ML roles granting Kibana privileges (elastic#80014) [Transform] remove old mixed cluster BWC layers, not required for 8x (elastic#79927) Increase test timeout for CoordinatorTests testAllSearchesExecuted [Transform] add rolling upgrade tests for upgrade endpoint (elastic#79721) [ML] Update trained model docs for truncate parameter for bert tokenization (elastic#79652) `CoordinatorTests` sometimes needs three term bumps (elastic#79574) [ML] Account for service being triggered twice in tests (elastic#80000) SearchContext: remove unused variable (elastic#79917) Revert "Deprecate resolution loss on date field (elastic#78921)" (elastic#79914) Re-enable GeoIpDownloaderIT#testStartWithNoDatabases() (elastic#79907) Fix SnapshotBasedIndexRecoveryIT#testSeqNoBasedRecoveryIsUsedAfterPrimaryFailOver (elastic#79469) Fix RecoverySourceHandlerTests (elastic#79546) SQL: stabilize SqlSearchPageTimeoutIT (elastic#79928) Wait 3 seconds for the server to reload trust (elastic#79778) Skip automatically preserved request headers when rewriting (elastic#79973) Check whether stdout is a real console (elastic#79882) Convert remote license checker to use LicensedFeature (elastic#79876) Miscellaneous fixes for LDAP SDK v6 upgrade (elastic#79891) ... # Conflicts: # libs/x-content/src/main/java/org/elasticsearch/xcontent/support/filtering/FilterPath.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathGeneratorFilteringTests.java # libs/x-content/src/test/java/org/elasticsearch/xcontent/support/filtering/FilterPathTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new "ConsoleLoader" that uses jANSI in a separate classloader
to determine whether standard output is a real console (that is, not
redirected to a file or /dev/null, etc)