Fix testBlobStoreCache#79747
Merged
elasticsearchmachine merged 3 commits intoelastic:masterfrom Oct 27, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Oct 26, 2021
| client().admin() | ||
| .cluster() | ||
| .prepareHealth() | ||
| .setIndices("restored-*") |
Contributor
There was a problem hiding this comment.
Can we simplify this to ensureGreen("restored-*")?
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 27, 2021
The attempt to fix this test in elastic#78616 wasn't complete: we need to wait for all mounted indices, not only the last restored one, before deleting the indices. Otherwise one of the mounted index might still be initializing and recreates the cached documents in `.snapshot-blob-cache` Closes elastic#78993
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member
Author
|
Thanks Henning |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 27, 2021
The attempt to fix this test in elastic#78616 wasn't complete: we need to wait for all mounted indices, not only the last restored one, before deleting the indices. Otherwise one of the mounted index might still be initializing and recreates the cached documents in `.snapshot-blob-cache` Closes elastic#78993
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 27, 2021
The attempt to fix this test in elastic#78616 wasn't complete: we need to wait for all mounted indices, not only the last restored one, before deleting the indices. Otherwise one of the mounted index might still be initializing and recreates the cached documents in `.snapshot-blob-cache` Closes elastic#78993
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 27, 2021
The attempt to fix this test in elastic#78616 wasn't complete: we need to wait for all mounted indices, not only the last restored one, before deleting the indices. Otherwise one of the mounted index might still be initializing and recreates the cached documents in `.snapshot-blob-cache` Closes elastic#78993
Member
Author
|
Annoying test failure so I backported on all affected branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attempt to fix this test in #78616 wasn't complete: we need to wait for all mounted indices, not only the last restored one, before deleting the indices. Otherwise one of the mounted index might still be initializing and recreates the cached documents in
.snapshot-blob-cacheCloses #78993