Change Monitoring plugin cluster alerts to not install by default#79657
Merged
jbaiera merged 2 commits intoelastic:masterfrom Oct 25, 2021
Merged
Change Monitoring plugin cluster alerts to not install by default#79657jbaiera merged 2 commits intoelastic:masterfrom
jbaiera merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
14 tasks
danhermann
approved these changes
Oct 25, 2021
Contributor
danhermann
left a comment
There was a problem hiding this comment.
LGTM. There's one unnecessary comma in the error message on the line below that pains my grammatical sensibilities 😅, but handle it as you prefer.
Member
Author
Overuse of commas is abhorrent and should be eschewed. |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
…astic#79657) Changes the default monitoring watches to not be installed by default any more. Tests have been updated to continue installing watches to make sure the installation process continues to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default monitoring watches to not be installed by default any more. Tests have been updated to continue installing watches to make sure the installation process continues to work.