Check for multiple javadocs in java headers#79603
Conversation
f115b08 to
0e0a853
Compare
There was a problem hiding this comment.
just cleaned that up on the way
There was a problem hiding this comment.
We now enforce to have the license statement on the very top of the java file before the package declaration
There was a problem hiding this comment.
We do some more stricter formatting on how the license statement looks. e.g. requiring a leading * and a line break after the first javadoc line /*
There was a problem hiding this comment.
This used to have two licenses declared. This seems wrong as apache license trumps sspl as far as I understand
There was a problem hiding this comment.
Yeah, unless we modified this code we should use the original license.
There was a problem hiding this comment.
Another occurrence of two licenses in on java file.
If this is legit we should put them in one javadoc block. Makes it more a conscious decision two have both here.
There was a problem hiding this comment.
Removed outdated elasticsearch license header
There was a problem hiding this comment.
another two licenses
There was a problem hiding this comment.
I think in this case we want to add @notice here so the original license is included in our distribution.
I'd also put our license after the orignal one and add Modifications copyright Elasticsearch B.V., then our license header.
There was a problem hiding this comment.
must be on the very top now before the package declaration
There was a problem hiding this comment.
as .* is greedy here we need to make this quite explicit. Happy to have recommendations to make this simpler.
mark-vieira
left a comment
There was a problem hiding this comment.
👍
I noticed that the newly forked elasticsearch-lz4 library doesn't have @notice in the source license headers. I believe it should since this is vendored code. Similarly we should add the "modifications copyright elastic..." bit below the original header.
There was a problem hiding this comment.
I think in this case we want to add @notice here so the original license is included in our distribution.
I'd also put our license after the orignal one and add Modifications copyright Elasticsearch B.V., then our license header.
6207f73 to
4b11697
Compare
|
Pinging @elastic/es-delivery (Team:Delivery) |
- Applies review feedback - some polishing on multiple licenses per file
ab652ee to
fd5faad
Compare
We also now enforce to have the license statement on the very top of the java file before the package declaration Fixes elastic#79235
Fixes #79235