Only remove active peer on connection failure#79557
Merged
elasticsearchmachine merged 1 commit intoelastic:masterfrom Oct 20, 2021
Merged
Conversation
Today if the `PeerFinder` experiences a connection failure then it removes the `Peer` with the corresponding transport address. However the removed `Peer` might be a different instance which is actually fine and holds a connection reference which therefore leaks. With this commit we only remove ourselves from the tracked set of peers. Relates elastic#77295 Closes elastic#79550
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
💚 Backport successful |
DaveCTurner
added a commit
that referenced
this pull request
Oct 20, 2021
Today if the `PeerFinder` experiences a connection failure then it removes the `Peer` with the corresponding transport address. However the removed `Peer` might be a different instance which is actually fine and holds a connection reference which therefore leaks. With this commit we only remove ourselves from the tracked set of peers. Relates #77295 Closes #79550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today if the
PeerFinderexperiences a connection failure then itremoves the
Peerwith the corresponding transport address. However theremoved
Peermight be a different instance which is actually fine andholds a connection reference which therefore leaks.
With this commit we only remove ourselves from the tracked set of peers.
Relates #77295
Closes #79550