More validation for routing_path#79520
Merged
nik9000 merged 7 commits intoelastic:masterfrom Oct 25, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This adds more validation for fields matching `routing_path`. In particular, it disallows runtime fields, fields with a `script`, and fails when you try to use `dynamic:false` to skip mapping them fields that would match the `routing_path`. This makes sure that the we get predictable time routing for the time series.
f50f2a3 to
60abb65
Compare
Member
Author
|
Thanks @imotov ! |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
This adds more validation for fields matching `routing_path`. In particular, it disallows runtime fields, fields with a `script`, and fails when you try to use `dynamic:false` to skip mapping them fields that would match the `routing_path`. This makes sure that the we get predictable time routing for the time series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more validation for fields matching
routing_path. Inparticular, it disallows runtime fields, fields with a
script, andfails when you try to use
dynamic:falseto skip mapping them fieldsthat would match the
routing_path. This makes sure that the we getpredictable time routing for the time series.