Don't always rewrite the Lucene query in search phases#79358
Merged
jimczi merged 2 commits intoelastic:masterfrom Oct 18, 2021
Merged
Don't always rewrite the Lucene query in search phases#79358jimczi merged 2 commits intoelastic:masterfrom
jimczi merged 2 commits intoelastic:masterfrom
Conversation
Today the Lucene query is rewritten eagerly in the dfs, query and fetch search phases. While this is needed in dfs and search, most of the fetch phases could avoid this cost. This change adds an explicit accessor for SearchContext that rewrites the original query once and returns its rewritten form. That allows to rewrite the Lucene query only when it's required.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
reviewed
Oct 18, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
Looks good, I left a couple of suggestions.
server/src/main/java/org/elasticsearch/search/fetch/subphase/FetchScorePhase.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/internal/SearchContext.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/internal/SearchContext.java
Show resolved
Hide resolved
hgmauri
approved these changes
Oct 18, 2021
jimczi
added a commit
that referenced
this pull request
Oct 18, 2021
Today the Lucene query is rewritten eagerly in the dfs, query and fetch search phases. While this is needed in dfs and search, most of the fetch phases could avoid this cost. This change adds an explicit accessor for SearchContext that rewrites the original query once and returns its rewritten form. That allows to rewrite the Lucene query only when it's required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the Lucene query is rewritten eagerly in the dfs, query and fetch search phases.
While this is needed in dfs and search, most of the fetch phases could avoid this cost.
This change adds an explicit accessor for SearchContext that rewrites the original query
once and returns its rewritten form. That allows to rewrite the Lucene query only when
it's required.