Filter Unneeded SnapshotInfo Instances Early in TransportGetSnapshotsAction (#78032)#79321
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Oct 17, 2021
original-brownbear:78032-7.x
Merged
Filter Unneeded SnapshotInfo Instances Early in TransportGetSnapshotsAction (#78032)#79321original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:78032-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:78032-7.x
Conversation
…Action (#78032) Better to filter as early as possible to release the memory asap and not even fetch things we don't need to fetch to begin with. There's still a bunch of spots remaining where similar optimizations can be added quickly before we implement the system index for the remaining searching/fetching that we can't easily exclude up-front. This already gives vastly improved performance for many requests though for obvious reasons.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
added a commit
that referenced
this pull request
Oct 19, 2021
Same as #79321 but for SLM policies. Enhances RepositoryData accordingly to enable the optimization.
original-brownbear
added a commit
that referenced
this pull request
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better to filter as early as possible to release the memory asap and not even fetch things we don't need to fetch to begin with.
There's still a bunch of spots remaining where similar optimizations can be added quickly before we implement the system index for the remaining searching/fetching that we can't easily exclude up-front.
This already gives vastly improved performance for many requests though for obvious reasons.
backport of #78032