Skip to content

Deprecation logs indexing is enabled by default#78991

Merged
pgomulka merged 5 commits intoelastic:masterfrom
pgomulka:enable_deprecation_log_indexing_and_turn_of_in_tests
Oct 13, 2021
Merged

Deprecation logs indexing is enabled by default#78991
pgomulka merged 5 commits intoelastic:masterfrom
pgomulka:enable_deprecation_log_indexing_and_turn_of_in_tests

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Oct 12, 2021

Changing the default for deprecation log indexing to be true.
This commit also overrides this default to tests where a deprecation
data stream would interfere - because it uses index template, it would
not be possible to delete with _index_template/*.
The overrides should be removed when #78850 is done.

closes #76292

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Changing the default for deprecation log indexing to be true.
This commit also overrides this defualt to tests where a deprecation
data stream would intefere - because it uses index template, it would
not be possible to delete with _index_template/*.
The overrides should be removed when elastic#78850 is done.

closes elastic#76292
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities and removed WIP labels Oct 12, 2021
@pgomulka pgomulka marked this pull request as ready for review October 12, 2021 18:32
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 12, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka changed the title [DRAFT] Deprecation logs indexing is enabled by default Deprecation logs indexing is enabled by default Oct 12, 2021
Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 78991

pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 13, 2021
Changing the default for deprecation log indexing to be true.
This commit also overrides this default to tests where a deprecation
data stream would interfere - because it uses index template, it would
not be possible to delete with _index_template/*.
The overrides should be removed when elastic#78850 is done.

closes elastic#76292
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 15, 2021
In order to prevent cluster to be in yellow state when starting up only
one node - often when testing or trying things - autoexpand should be
set on that data stream

Also to making sure the deprecation log indexing is disabled on all
nodes in mixed-cluster and rolling upgrade

relates elastic#78991
pgomulka added a commit that referenced this pull request Oct 15, 2021
In order to prevent cluster to be in yellow state when starting up only
one node - often when testing or trying things - autoexpand should be
set on that data stream

Also to making sure the deprecation log indexing is disabled on all
nodes in mixed-cluster and rolling upgrade

relates #78991
pgomulka added a commit that referenced this pull request Oct 18, 2021
…9035)

Changing the default for deprecation log indexing to be true.
This commit also overrides this default to tests where a deprecation
data stream would interfere - because it uses index template, it would
not be possible to delete with _index_template/*.
The overrides should be removed when #78850 is done.

closes #76292
backport #78991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Logging Log management and logging utilities >deprecation Team:Core/Infra Meta label for core/infra team v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable deprecation log indexing by default

6 participants