Skip to content

Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigned(...)#78931

Merged
martijnvg merged 4 commits intoelastic:masterfrom
martijnvg:replace_routing_table_shards_with_state_with_routing_nodes_shards_with_state
Oct 12, 2021
Merged

Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigned(...)#78931
martijnvg merged 4 commits intoelastic:masterfrom
martijnvg:replace_routing_table_shards_with_state_with_routing_nodes_shards_with_state

Conversation

@martijnvg
Copy link
Copy Markdown
Member

@martijnvg martijnvg commented Oct 11, 2021 •
edited
Loading

Replaces only the production use cases of RoutingTable#shardsWithState(...).

Relates to #77466

@martijnvg martijnvg added >enhancement :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.0.0 v7.16.0 labels Oct 11, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Oct 11, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 11, 2021

Pinging @elastic/es-distributed (Team:Distributed)

DaveCTurner
DaveCTurner reviewed Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use RoutingNodes#unassigned() to iterate over the unassigned shards directly rather than copying them to an intermediate list first?

@martijnvg
Copy link
Copy Markdown
Member Author

martijnvg commented Oct 11, 2021

Could we use RoutingNodes#unassigned() to iterate over the unassigned shards directly rather than copying them to an intermediate list first?

Yes, pushed via: 9f88b6e

original-brownbear
original-brownbear approved these changes Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martijnvg
Copy link
Copy Markdown
Member Author

martijnvg commented Oct 12, 2021

@elasticmachine run elasticsearch-ci/docs

@martijnvg martijnvg merged commit 9702d3f into elastic:master Oct 12, 2021
@martijnvg martijnvg changed the title Replace RoutingTable#shardsWithState(...) with RoutingNodes#shardsWithState(...) Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigned(...) Oct 12, 2021
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Oct 12, 2021
@martijnvg
Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigne…
24e7025 
…d(...) (elastic#78931)

Replaces only the production use cases of `RoutingTable#shardsWithState(...)` with `RoutingNodes#unassigned()`.

Relates to elastic#77466
@martijnvg martijnvg mentioned this pull request Oct 12, 2021
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 12, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

@martijnvg martijnvg mentioned this pull request Oct 12, 2021
Merged
elasticsearchmachine pushed a commit that referenced this pull request Oct 12, 2021
@martijnvg
Replace RoutingTable#shardsWithState(...) with RoutingNodes#unassigne…
75e020e 
…d(...) (#78931) (#78956)

Replaces only the production use cases of `RoutingTable#shardsWithState(...)` with `RoutingNodes#unassigned()`.

Relates to #77466
@original-brownbear original-brownbear mentioned this pull request Oct 12, 2021
Open
97 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner left review comments

+1 more reviewer

@original-brownbear original-brownbear original-brownbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >enhancement Team:Distributed Meta label for distributed team. v7.16.0 v8.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@martijnvg @elasticmachine @elasticsearchmachine @DaveCTurner @original-brownbear @jakelandis