Add v7 restCompat for invalidating API key with the id field#78664
Merged
ywangd merged 5 commits intoelastic:masterfrom Oct 11, 2021
Merged
Add v7 restCompat for invalidating API key with the id field#78664ywangd merged 5 commits intoelastic:masterfrom
ywangd merged 5 commits intoelastic:masterfrom
Conversation
This PR restore the id field for InvaliateApiKey API so it can be used if the request explicitly requires v7 compatibility. Relates: elastic#66671
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Member
Author
|
The 7.x branch currently does not have any YAML tests to excercise the deprecated |
Member
Author
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
Member
Author
|
@elasticmachine update branch |
ywangd
added a commit
that referenced
this pull request
Oct 6, 2021
Temporarily mute till #78664 gets merged.
tvernum
approved these changes
Oct 6, 2021
|
|
||
| private ConstructingObjectParser<InvalidateApiKeyRequest, Void> getObjectParser(RestRequest request) { | ||
| if (request.getRestApiVersion() == RestApiVersion.V_7) { | ||
| final ConstructingObjectParser<InvalidateApiKeyRequest, Void> objectParser = new ConstructingObjectParser<>( |
Contributor
There was a problem hiding this comment.
Is there a reason this isn't a static final field like the non-compat parser?
I'm not particularly fussed either way, it just surprised me.
Member
Author
There was a problem hiding this comment.
My thinking is to minimize the overhead of restCompat to normal v8 usage (at the same time accept a bit more overhead for restCompat). So this v7 parser does not have to exist if client never uses v7 rest compat. It's probably a marginal saving. But recent focus on performance issue led me to this.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Oct 11, 2021
* upstream/master: (250 commits) [Transform] HLRC cleanups (elastic#78909) [ML] Make ML indices hidden when the node becomes master (elastic#77416) Introduce a Few Settings Singleton Instances (elastic#78897) Simplify TestCluster extraJar configuration (elastic#78837) Add @OverRide annotations to methods in EnrichPlugin class (elastic#76873) Add v7 restCompat for invalidating API key with the id field (elastic#78664) EQL: Refine repeatable queries (elastic#78895) Fix DataTierTests package and add a validation test (elastic#78880) Fix split package org.elasticsearch.common.xcontent (elastic#78831) Store DataTier Preference directly on IndexMetadata (elastic#78668) [DOCS] Fixes typo in calendar API example (elastic#78867) Improve Node Shutdown Observability (elastic#78727) Convert encrypted snapshot license object to LicensedFeature (elastic#78731) Revert "Make nodePaths() singular (elastic#72514)" (elastic#78801) Fix incorrect generic type in PolicyStepsRegistry (elastic#78628) [DOCS] Fixes ML get calendars API (elastic#78808) Implement GET API for System Feature Upgrades (elastic#78642) [TEST] More MetadataStateFormat tests (elastic#78577) Add support for rest compatibility headers to the HLRC (elastic#78490) Un-ignoring tests after backporting fix (elastic#78830) ... # Conflicts: # server/src/main/java/org/elasticsearch/ingest/IngestService.java # server/src/test/java/org/elasticsearch/ingest/IngestServiceTests.java
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Oct 29, 2021
RestCompat for invalidate API key with a single id is merged. The test can now be enabled. Relates: elastic#78664
ywangd
added a commit
that referenced
this pull request
Nov 3, 2021
RestCompat for invalidate API key with a single id is merged. The test can now be enabled. Relates: #78664
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Nov 3, 2021
) RestCompat for invalidate API key with a single id is merged. The test can now be enabled. Relates: elastic#78664
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restore the id field for InvaliateApiKey API so it can be used
if the request explicitly requires v7 compatibility.
Relates: #66671