Fix Empty Step Info not Comparing Correctly#78442
Merged
original-brownbear merged 1 commit intoelastic:masterfrom Sep 29, 2021
original-brownbear:empty-step-info-equals
Merged
Fix Empty Step Info not Comparing Correctly#78442original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:empty-step-info-equals
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:empty-step-info-equals
Conversation
Follow up to #78390. The `EmptyInfo` would not compare correctly because it doesn't implement equals or hashcode, breaking deduplication for `SetStepInfoUpdateTask`. => just making it a singleton to fix this and have a fast comp via instance equality.
original-brownbear
added a commit
that referenced
this pull request
Sep 29, 2021
Follow up to #78390. The `EmptyInfo` would not compare correctly because it doesn't implement equals or hashcode, breaking deduplication for `SetStepInfoUpdateTask`. => just making it a singleton to fix this and have a fast comp via instance equality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #78390. The
EmptyInfowould not comparecorrectly because it doesn't implement equals or hashcode,
breaking deduplication for
SetStepInfoUpdateTask.=> just making it a singleton to fix this and have a fast comp via
instance equality.