Skip to content

Deprecate returning 408 for a server timeout on _cluster/health#78180

Merged
arteam merged 52 commits intoelastic:masterfrom
arteam:return-200-for-cluster-health-timeout
Oct 11, 2021
Merged

Deprecate returning 408 for a server timeout on _cluster/health#78180
arteam merged 52 commits intoelastic:masterfrom
arteam:return-200-for-cluster-health-timeout

Conversation

@arteam
Copy link
Copy Markdown
Contributor

@arteam arteam commented Sep 22, 2021 •
edited
Loading

Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0

Fixes #70849

@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Sep 22, 2021

@elasticmachine update branch

@arteam arteam force-pushed the return-200-for-cluster-health-timeout branch 2 times, most recently from d40180f to 978a748 Compare September 22, 2021 22:03
@arteam arteam changed the title Return correct HTTP code for a server timeout on _cluster/health Return a HTTP 200 code for a server timeout on _cluster/health Sep 23, 2021
@arteam arteam force-pushed the return-200-for-cluster-health-timeout branch from 978a748 to 97499e7 Compare September 23, 2021 09:01
@arteam arteam marked this pull request as ready for review September 23, 2021 18:21
@arteam arteam added the :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Sep 27, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Sep 27, 2021
@arteam arteam marked this pull request as draft September 27, 2021 17:25
@elastic elastic deleted a comment from elasticmachine Sep 27, 2021
@arteam arteam force-pushed the return-200-for-cluster-health-timeout branch from 61f862f to 231c884 Compare September 27, 2021 17:32
@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Sep 30, 2021

@elasticmachine update branch

@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Oct 11, 2021

@elasticmachine run elasticsearch-ci/bwc

@arteam
Copy link
Copy Markdown
Contributor Author

arteam commented Oct 11, 2021

@elasticmachine update branch

@arteam arteam merged commit f266eb3 into elastic:master Oct 11, 2021
@arteam arteam deleted the return-200-for-cluster-health-timeout branch October 11, 2021 19:05
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 11, 2021

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 78180

arteam added a commit to arteam/elasticsearch that referenced this pull request Oct 11, 2021
@arteam
[7.x] Deprecate returning 408 for a server timeout on `_cluster/healt…
07f5e9d 
…h` (elastic#78180)

Backports elastic#78180 to 7.x.

Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0

Fixes elastic#70849
@arteam arteam mentioned this pull request Oct 11, 2021
Merged
arteam added a commit that referenced this pull request Oct 11, 2021
@arteam
[7.x] Deprecate returning 408 for a server timeout on `_cluster/healt…
03bd55d 
…h` (#78180) (#78940)

Backports #78180 to 7.x.

Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0

Fixes #70849
@arteam arteam mentioned this pull request Oct 13, 2021
Merged
@DaveCTurner DaveCTurner mentioned this pull request Oct 19, 2021
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 19, 2021
@DaveCTurner
Add deprecation docs for cluster health HTTP code
b123408 
Documents the deprecation introduced in elastic#78180 and adjusted in elastic#79351.
DaveCTurner added a commit that referenced this pull request Oct 19, 2021
@DaveCTurner
Add deprecation docs for cluster health HTTP code (#79451)
9184b4c 
Documents the deprecation introduced in #78180 and adjusted in #79351.
arteam added a commit that referenced this pull request Nov 6, 2021
@arteam
Return 200 OK response code for a cluster health timeout (#78968)
a2c3dae 
Returning 408 for a cluster health timeout was deprecated in #78180 and backported to 7.x in #78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes #70849
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 6, 2021
@arteam
Return 200 OK response code for a cluster health timeout (elastic#78968)
9ad8439 
Returning 408 for a cluster health timeout was deprecated in elastic#78180 and backported to 7.x in elastic#78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes elastic#70849
arteam added a commit that referenced this pull request Nov 8, 2021
@arteam
Return 200 OK response code for a cluster health timeout (#78968) (#8…
7937f67 
…0464)

Returning 408 for a cluster health timeout was deprecated in #78180 and backported to 7.x in #78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes #70849
@arteam arteam mentioned this pull request Nov 18, 2021
Merged
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
@arteam
Revert "Deprecate returning 408 for a server timeout on `_cluster/hea…
af31969 
…lth` (elastic#78180)"

This reverts commit f266eb3
@arteam arteam mentioned this pull request Nov 18, 2021
Merged
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
@arteam
Revert "Deprecate returning 408 for a server timeout on `_cluster/hea…
3287dcb 
…lth` (elastic#78180)"

This reverts commit f266eb3
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
@arteam
Revert "[7.x] Deprecate returning 408 for a server timeout on `_clust…
bfb78b2 
…er/health` (elastic#78180) (elastic#78940)"

This reverts commit 03bd55d
@arteam arteam mentioned this pull request Nov 18, 2021
Merged
arteam added a commit that referenced this pull request Nov 18, 2021
@arteam
[7.16] Revert "Deprecate returning 408 for a server timeout on `_clus…
47da0dc 
…ter/health` (#78180)" (#80831)

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)"

This reverts commit 5a53007.

* Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)"

This reverts commit d8c1428

* Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)"

This reverts commit 03bd55d
arteam added a commit that referenced this pull request Nov 18, 2021
@arteam
[8.0] Revert "Return 200 OK response code for a cluster health timeout (
d8b5bfe 
#78968)" (#80826)

* [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)"

This reverts commit a2c3dae

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)"

This reverts commit 4102cf7.

* Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)"

This reverts commit b9fbe66.

* Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)"

This reverts commit f60bda5.

* Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)"

This reverts commit 8901a99

* Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)"

This reverts commit f266eb3

* Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)

This reverts commit fa4d562.

* Revert "[8.0] Disable BWC for #80821 (#80840)"
arteam added a commit that referenced this pull request Nov 18, 2021
@arteam @elasticmachine
Revert "Return 200 OK response code for a cluster health timeout (#78968
89bbac9 
)" (#80821)

* Revert "Return 200 OK response code for a cluster health timeout (#78968)"

This reverts commit a2c3dae

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178)"

This reverts commit 1c711e3.

* Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)"

This reverts commit b9fbe66.

* Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)"

This reverts commit f60bda5.

* Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)"

This reverts commit 8901a99

* Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)"

This reverts commit f266eb3

* Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)

This reverts commit fa4d562

* Revert "Disable BWC for #80821 (#80839)"

This reverts commit cb0e73e.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >deprecation :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed Meta label for distributed team. v8.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix HTTP response code for cluster health API

5 participants

@arteam @elasticmachine @elasticsearchmachine @DaveCTurner @jakelandis