[ML] Job updates in tests should not update blocked on deleting jobs#78169
Merged
dimitris-athanasiou merged 2 commits intoelastic:masterfrom Sep 22, 2021
Conversation
Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes elastic#78160
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Sep 22, 2021
…lastic#78169) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes elastic#78160
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Sep 22, 2021
…lastic#78169) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes elastic#78160
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Sep 22, 2021
…lastic#78169) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes elastic#78160
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2021
…78169) (#78174) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes #78160
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2021
…78169) (#78173) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes #78160
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 22, 2021
…78169) (#78172) Deleting jobs do not allow for their `blocked` field to be changed from `delete`. Tests were creating job updates that ignored that leading to a test failure when a non-noop update made no change to a job. This commit ensures random job updates do not have a change to the `blocked` field for deleting jobs. Closes #78160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting jobs do not allow for their
blockedfield to be changedfrom
delete. Tests were creating job updates that ignored thatleading to a test failure when a non-noop update made no change to
a job. This commit ensures random job updates do not have a change
to the
blockedfield for deleting jobs.Closes #78160