Fix split package in reindex module#78141
Merged
rjernst merged 2 commits intoelastic:masterfrom Sep 22, 2021
Merged
Conversation
The reindex module reuses the server package o.e.index.reindex. This commit moves the classes in the reindex module into o.e.reindex. While it may be confusing to have two different leave "reindex" packages, this at least moves us towards having each module match the package name of its implementation, one step closer towards jigsaw modules.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
nik9000
approved these changes
Sep 21, 2021
Member
nik9000
left a comment
There was a problem hiding this comment.
👍. Make the jigsaw gods happy.
58 tasks
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 22, 2021
The reindex module reuses the server package o.e.index.reindex. This commit moves the classes in the reindex module into o.e.reindex. While it may be confusing to have two different leave "reindex" packages, this at least moves us towards having each module match the package name of its implementation, one step closer towards jigsaw modules.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Fix split package in reindex module (#78141) The reindex module reuses the server package o.e.index.reindex. This commit moves the classes in the reindex module into o.e.reindex. While it may be confusing to have two different leave "reindex" packages, this at least moves us towards having each module match the package name of its implementation, one step closer towards jigsaw modules. * fix transport client ref * fix compile * fix imports * spotless * remove import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reindex module reuses the server package o.e.index.reindex. This
commit moves the classes in the reindex module into o.e.reindex. While
it may be confusing to have two different leave "reindex" packages, this
at least moves us towards having each module match the package name of
its implementation, one step closer towards jigsaw modules.