Fix split package in annotated text plugin#78133
Merged
rjernst merged 2 commits intoelastic:masterfrom Sep 21, 2021
Merged
Conversation
The annotated text mapper plugin reuses package names from server. This commit moves the implementation classes into an annotated text package specifically for the plugin.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
approved these changes
Sep 21, 2021
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
This also looks good to me! It seems like we're converging on a naming convention of org.elasticsearch.index.mapper... for mapper plugins and modules.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 21, 2021
The annotated text mapper plugin reuses package names from server. This commit moves the implementation classes into an annotated text package specifically for the plugin.
Collaborator
💚 Backport successful
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The annotated text mapper plugin reuses package names from server. This
commit moves the implementation classes into an annotated text package
specifically for the plugin.