Fix split packages in analysis-ukranian plugin#78046
Merged
rjernst merged 3 commits intoelastic:masterfrom Sep 21, 2021
Merged
Conversation
The analysis-ukranian plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.ukranian Note that XUkrainianMorfologikAnalyzer does not need to be in the ukranian lucene package, it works fine since it is a soft fork, not a subclass.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Sep 21, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, one nit re license headers
| @@ -1,3 +1,11 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
I don't think we want to relicense here?
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 21, 2021
The analysis-ukranian plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.ukranian Note that XUkrainianMorfologikAnalyzer does not need to be in the ukranian lucene package, it works fine since it is a soft fork, not a subclass.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
The analysis-ukranian plugin reuses server the server package name for analysis. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.ukranian Note that XUkrainianMorfologikAnalyzer does not need to be in the ukranian lucene package, it works fine since it is a soft fork, not a subclass.
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analysis-ukranian plugin reuses server the server package name for
analysis. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.ukranian
Note that XUkrainianMorfologikAnalyzer does not need to be in the
ukranian lucene package, it works fine since it is a soft fork, not a
subclass.