Skip to content

[DOCS] Add breaking change for ECS user agent#77971

Merged
jrodewig merged 4 commits intoelastic:masterfrom
jrodewig:docs__remove-ecs-param
Sep 21, 2021
Merged

[DOCS] Add breaking change for ECS user agent#77971
jrodewig merged 4 commits intoelastic:masterfrom
jrodewig:docs__remove-ecs-param

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Sep 17, 2021 •
edited
Loading

In 8.x, we'll ignore the ecs option for the user_agent ingest processor.
This adds a related breaking change to the 8.0 migration docs.

Relates to #38828

Preview

https://elasticsearch_77971.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_ingest_changes

@jrodewig
[DOCS] Add breaking change for ECS user agent
f448627 
In 8.x, we'll ignore the `ecs` option for the `user_agent` ingest processor.
This adds a related breaking change to the 8.0 migration docs.

Relates to #38828
@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Sep 17, 2021 •
edited
Loading

I was surprised to see that specifying the ecs parameter doesn't return an error in 8.0. Instead, it looks like you get a deprecation warning.

elasticsearch/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java

Lines 194 to 198 in 6c4c5e2

Object ecsValue = config.remove("ecs");
if (ecsValue != null) {
deprecationLogger.critical(DeprecationCategory.SETTINGS, "ingest_useragent_ecs_settings",
"setting [ecs] is deprecated as ECS format is the default and only option");
}

@jrodewig jrodewig added :Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes labels Sep 17, 2021
@jrodewig jrodewig marked this pull request as ready for review September 17, 2021 15:31
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. labels Sep 17, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Sep 17, 2021

Pinging @elastic/es-data-management (Team:Data Management)

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Sep 17, 2021

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig mentioned this pull request Sep 17, 2021
Merged
@jrodewig jrodewig merged commit 49444cc into elastic:master Sep 21, 2021
@jrodewig jrodewig deleted the docs__remove-ecs-param branch September 21, 2021 13:19
jrodewig added a commit to elastic/stack-docs that referenced this pull request Sep 21, 2021
@jrodewig
[DOCS] Add ES breaking changes section for ingest pipelines (#1820)
239d855 
Depends on elastic/elasticsearch#77971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masseyke masseyke masseyke approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

Assignees

No one assigned

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v8.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jrodewig @elasticmachine @masseyke @jakelandis @elasticsearchmachine