Skip to content

Document missing_order param for composite aggregations#77839

Merged
Luegg merged 2 commits intoelastic:masterfrom
Luegg:enhance/missingOrderDocs
Sep 27, 2021
Merged

Document missing_order param for composite aggregations#77839
Luegg merged 2 commits intoelastic:masterfrom
Luegg:enhance/missingOrderDocs

Conversation

@Luegg
Copy link
Copy Markdown
Contributor

@Luegg Luegg commented Sep 16, 2021

Documents the missing_order parameter for composite aggregations introduced in #76740

@Luegg Luegg added >docs General docs changes :Docs v8.0.0 v7.16.0 labels Sep 16, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Sep 16, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a minor typo. I made a lengthier suggestion that you can ignore if wanted.

Thanks @Luegg!

documents without a value for the field `product` and the bucket will be placed last.

The position of the `null` bucket can be controlled with the optional `missing_order`
parameter. If `missing_order` is `first` or last `last`, the `null` bucket will be placed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Suggested change
parameter. If `missing_order` is `first` or last `last`, the `null` bucket will be placed
parameter. If `missing_order` is `first` or `last`, the `null` bucket will be placed

@jrodewig jrodewig removed the :Docs label Sep 16, 2021
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Copy link
Copy Markdown
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luegg Luegg merged commit 421b3e8 into elastic:master Sep 27, 2021
@Luegg Luegg deleted the enhance/missingOrderDocs branch September 27, 2021 07:57
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
7.x

Luegg added a commit to Luegg/elasticsearch that referenced this pull request Sep 27, 2021
Documents the missing_order parameter for composite aggregations introduced in elastic#76740
elasticsearchmachine pushed a commit that referenced this pull request Sep 27, 2021
)

Documents the missing_order parameter for composite aggregations introduced in #76740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants