Skip to content

[DOCS] Add deprecation docs for incompatible builds#77730

Merged
jrodewig merged 1 commit intoelastic:7.xfrom
jrodewig:docs__deprecate-permit-handshake
Sep 16, 2021
Merged

[DOCS] Add deprecation docs for incompatible builds#77730
jrodewig merged 1 commit intoelastic:7.xfrom
jrodewig:docs__deprecate-permit-handshake

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Sep 14, 2021 •
edited
Loading

We deprecated the es.unsafely_permit_handshake_from_incompatible_builds system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.

Preview

https://elasticsearch_77730.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/7.x/migrating-7.11.html#deprecate-unsafely_permit_handshake_from_incompatible_builds

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Sep 14, 2021

@elasticmachine test this please

@jrodewig
[DOCS] Add deprecation docs for `es.unsafely_permit_handshake_from_in…
6605b4d 
…compatible_builds`

We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
@jrodewig jrodewig marked this pull request as ready for review September 14, 2021 22:22
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Sep 14, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Sep 14, 2021

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added the :Distributed/Network Http and internode communication implementations label Sep 14, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Sep 14, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Sep 14, 2021

Pinging @elastic/es-distributed (Team:Distributed)

DaveCTurner
DaveCTurner approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2 although IMO it'd also be fine not to document this, we deliberately didn't document the setting in the first place, we just added it in case we had an emergency need to bypass those checks but we've never had such a need.

@jrodewig
Copy link
Copy Markdown
Contributor Author

jrodewig commented Sep 16, 2021

Thanks @DaveCTurner @masseyke!

IMO it'd also be fine not to document this, we deliberately didn't document the setting in the first place, we just added it in case we had an emergency need to bypass those checks but we've never had such a need.

I'll go ahead and merge/publish this since we have a corresponding breaking change in the 8.0 docs:
https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_transport_changes

Probably out of scope for this PR, but we should consider the criteria for not documenting a breaking change. We have quite a few for 8.0. It'd be great for users to have to parse through fewer of them.

@jrodewig jrodewig merged commit 8402d6d into elastic:7.x Sep 16, 2021
@jrodewig jrodewig deleted the docs__deprecate-permit-handshake branch September 16, 2021 21:25
This was referenced Sep 16, 2021
Merged
Merged
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77960)
9332e5f 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77961)
68fa321 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77962)
b6af7e1 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77963)
b77322a 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77964)
68a28c9 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masseyke masseyke masseyke approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

@jbaiera jbaiera Awaiting requested review from jbaiera

Assignees

No one assigned

Labels

:Distributed/Network Http and internode communication implementations >docs General docs changes Team:Distributed Meta label for distributed team. Team:Docs Meta label for docs team v7.11.3 v7.12.2 v7.13.5 v7.14.3 v7.15.1 v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrodewig @elasticmachine @masseyke @DaveCTurner