fix composite aggregation tests failing after #76740#77691
Merged
Luegg merged 5 commits intoelastic:masterfrom Sep 15, 2021
Merged
fix composite aggregation tests failing after #76740#77691Luegg merged 5 commits intoelastic:masterfrom
Luegg merged 5 commits intoelastic:masterfrom
Conversation
e303fd0 to
4dacb95
Compare
4dacb95 to
97b8d00
Compare
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Contributor
Author
|
|
not-napoleon
approved these changes
Sep 14, 2021
Member
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. Thanks for jumping on this!
nik9000
approved these changes
Sep 15, 2021
Member
nik9000
left a comment
There was a problem hiding this comment.
LGTM. Good luck with the backport dance. That takes a while.
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Sep 15, 2021
…77691) Follow up of elastic#77650. Looks like two issues caused occasional failures: missingOrder has not been considered in InternalComposite.InternalBucket#compareKey reverseMul has been ignored in one case in OrdinalValuesSource#compareInternal The first problem has clearly been introduced by elastic#76740 but the second point is more interesting. As far as I understand, this might have caused problems before but I couldn't find any according test failures in Gradle before yesterday. In order to preclude further rare test failures I've run the whole CompositeAggregatorTests 3000 times and all tests turned green. # Conflicts: # server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/InternalComposite.java
Luegg
pushed a commit
to Luegg/elasticsearch
that referenced
this pull request
Sep 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
Follow up of #77650. Looks like two issues caused occasional failures: missingOrder has not been considered in InternalComposite.InternalBucket#compareKey reverseMul has been ignored in one case in OrdinalValuesSource#compareInternal The first problem has clearly been introduced by #76740 but the second point is more interesting. As far as I understand, this might have caused problems before but I couldn't find any according test failures in Gradle before yesterday. In order to preclude further rare test failures I've run the whole CompositeAggregatorTests 3000 times and all tests turned green. # Conflicts: # server/src/main/java/org/elasticsearch/search/aggregations/bucket/composite/InternalComposite.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #77650.
Looks like two issues caused occasional failures:
missingOrderhas not been considered inInternalComposite.InternalBucket#compareKeyreverseMulhas been ignored in one case inOrdinalValuesSource#compareInternalThe first problem has clearly been introduced by #76740 but the second point is more interesting. As far as I understand, this might have caused problems before but I couldn't find any according test failures in Gradle before yesterday.
In order to preclude further rare test failures I've run the whole
CompositeAggregatorTests3000 times and all tests turned green.