Fix failing die with dignity test#77373
Merged
jasontedor merged 1 commit intoelastic:masterfrom Sep 8, 2021
Merged
Conversation
This test sometimes spuriously fails because we are looking for a specific string in the command line, but jps truncates the output to 1024 characters. Sometimes, the string we are looking for is beyond 1024 characters in the command line. This commit changes the tactic, to instead use jcmd to find the command line of all running JVMs on the machine, and then look for the specific string there. This circumvents the truncation issue.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
AthenaEryma
approved these changes
Sep 7, 2021
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM, thanks for digging in and fixing!
Contributor
|
Just saw #77385, that'll teach me to refresh the page for comments before reviewing. I don't have strong opinions about which approach we should take. |
rjernst
approved these changes
Sep 8, 2021
jasontedor
added a commit
that referenced
this pull request
Sep 8, 2021
This test sometimes spuriously fails because we are looking for a specific string in the command line, but jps truncates the output to 1024 characters. Sometimes, the string we are looking for is beyond 1024 characters in the command line. This commit changes the tactic, to instead use jcmd to find the command line of all running JVMs on the machine, and then look for the specific string there. This circumvents the truncation issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test sometimes spuriously fails because we are looking for a specific string in the command line, but jps truncates the output to 1024 characters. Sometimes, the string we are looking for is beyond 1024 characters in the command line. This commit changes the tactic, to instead use jcmd to find the command line of all running JVMs on the machine, and then look for the specific string there. This circumvents the truncation issue.
Closes #77282