Fix NumberFieldMapper Referencing its Own Builder#77131
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Sep 2, 2021
original-brownbear:smaller-num-field-mapper
Merged
Fix NumberFieldMapper Referencing its Own Builder#77131original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:smaller-num-field-mapper
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:smaller-num-field-mapper
Conversation
Investigating the heap use of mapper instances I found this. It seems quite a bit of overhead for these instances goes into the builder field. In other mappers we retain the script service and the script outright, so I did the same thing here to make these instances a little smaller.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
reviewed
Sep 1, 2021
Contributor
|
@romseygeek I think you investigated a very similar issue a few months ago? |
Contributor
Author
Right, didn't even notice that :) Makes sense to me, unless @romseygeek has objections? :) |
romseygeek
approved these changes
Sep 2, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
@yannick found a similar problem with text fields using this pattern a few weeks ago. We should definitely fix it - I have a longer term plan to rework how merges are done so that we only use builders and don't need to hold references to all these helper components but in the short term this is a good fix.
Contributor
Author
|
Thanks @romseygeek ! |
Contributor
|
Relates #73845 |
original-brownbear
added a commit
that referenced
this pull request
Sep 2, 2021
Investigating the heap use of mapper instances I found this. It seems quite a bit of overhead for these instances goes into the builder field. In other mappers we retain the script service and the script outright, so I did the same thing here to make these instances a little smaller.
original-brownbear
added a commit
that referenced
this pull request
Sep 3, 2021
97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating the heap use of mapper instances I found this.
It seems quite a bit of overhead for these instances goes into
the builder field. In other mappers we retain the script service
and the script outright, so I did the same thing here to make these
instances a little smaller.