Centralize doc values checking#77089
Merged
nik9000 merged 1 commit intoelastic:masterfrom Sep 1, 2021
Merged
Conversation
This adds two utility methods for to validate the parameters to the `docValueFormat` method and replaces a pile of copy and pasted code with calls to them. They just emit a standard error message if the any unsupported parameters are provided.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
approved these changes
Sep 1, 2021
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Sep 1, 2021
This adds two utility methods for to validate the parameters to the `docValueFormat` method and replaces a pile of copy and pasted code with calls to them. They just emit a standard error message if the any unsupported parameters are provided.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 1, 2021
This adds two utility methods for to validate the parameters to the `docValueFormat` method and replaces a pile of copy and pasted code with calls to them. They just emit a standard error message if the any unsupported parameters are provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two utility methods for to validate the parameters to the
docValueFormatmethod and replaces a pile of copy and pasted code withcalls to them. They just emit a standard error message if the any
unsupported parameters are provided.