Skip to content

[Test] More robust assertions for sorting and pagination#76654

Merged
ywangd merged 2 commits intoelastic:masterfrom
ywangd:es-76542-distinct-results
Aug 24, 2021
Merged

[Test] More robust assertions for sorting and pagination#76654
ywangd merged 2 commits intoelastic:masterfrom
ywangd:es-76542-distinct-results

Conversation

@ywangd
Copy link
Copy Markdown
Member

@ywangd ywangd commented Aug 18, 2021

Pagination does not use _doc anymore since it could change between requests
for things like segment merging, hitting on a different replica.

Resolves: #76542

Remove potential duplicates from results gathered with sorting
and search_after. Pagination does not use _doc anymore since it could
change between requests.

Resolves: elastic#76542
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label v8.0.0 v7.15.0 labels Aug 18, 2021
@ywangd ywangd requested a review from tvernum August 18, 2021 13:03
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Aug 18, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

@ywangd ywangd merged commit a5a1c6a into elastic:master Aug 24, 2021
wjp719 added a commit to wjp719/elasticsearch that referenced this pull request Aug 24, 2021
* master: (21 commits)
  [Test] More robust assertions for sorting and pagination (elastic#76654)
  [Test] Fix filename check on Windows (elastic#76807)
  Upgrade build scan plugin to 3.6.4 (elastic#76784)
  Remove keystore initial_md5sum (elastic#76835)
  Don't export docker images on assemble (elastic#76817)
  Fix testMasterStatsOnSuccessfulUpdate (elastic#76844)
  AwaitsFix for elastic#76840
  Make Releasing Aggregation Buffers Safer (elastic#76741)
  Re-enable BWC tests after backport of elastic#76771 (elastic#76839)
  Dispatch large bulk requests to write thread  (elastic#76736)
  Disable BWC tests for elastic#76771
  Pull down beats artifacts when performing release tests
  Add timing stats to publication process (elastic#76771)
  Fix BanFailureLoggingTests some more (elastic#76668)
  Mention "warn threshold" in master service slowlog (elastic#76815)
  Fix DockerTests.test010Install
  Re-enable tests affected by elastic#75097 (elastic#76814)
  Fix testRecoveryIsCancelledAfterDeletingTheIndex (elastic#76644)
  Test fix -WildcardFieldMapperTests bad test data. (elastic#76819)
  Updating supported version after backporting the feature (elastic#76794)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 24, 2021
Remove potential duplicates from results gathered with sorting
and search_after. Pagination does not use _doc anymore since it could
change between requests.

Resolves: elastic#76542
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 24, 2021
Remove potential duplicates from results gathered with sorting
and search_after. Pagination does not use _doc anymore since it could
change between requests.

Resolves: elastic#76542
elasticsearchmachine pushed a commit that referenced this pull request Aug 24, 2021
…6859)

Remove potential duplicates from results gathered with sorting
and search_after. Pagination does not use _doc anymore since it could
change between requests.

Resolves: #76542
elasticsearchmachine pushed a commit that referenced this pull request Aug 24, 2021
…6858)

Remove potential duplicates from results gathered with sorting
and search_after. Pagination does not use _doc anymore since it could
change between requests.

Resolves: #76542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-alpha2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] QueryApiKeyIT testPagination failing

5 participants