HLRC support for query API key API#76520
Merged
ywangd merged 5 commits intoelastic:masterfrom Aug 17, 2021
Merged
Conversation
fbdfaa6 to
898c71d
Compare
5 tasks
749f9e3 to
40e49ad
Compare
40e49ad to
9f8c5a0
Compare
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
Aug 16, 2021
| return metadata; | ||
| } | ||
|
|
||
| public Object[] getSortValues() { |
Contributor
There was a problem hiding this comment.
Should we javadoc this method?
We typically don't (and rely on the API docs) but this field is weird, since it only exists for ApiKey objects that came from _query/
Member
Author
There was a problem hiding this comment.
Good point. Added, thanks!
...high-level/src/test/java/org/elasticsearch/client/documentation/SecurityDocumentationIT.java
Outdated
Show resolved
Hide resolved
…documentation/SecurityDocumentationIT.java Co-authored-by: Tim Vernum <tim@adjective.org>
Member
Author
|
@elasticmachine update branch |
Collaborator
💔 Backport failed
To backport manually run |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Aug 17, 2021
This PR adds HLRC for the new Query API key API added with elastic#75335 and elastic#76144 Relates: elastic#71023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds HLRC for the new Query API key API added with #75335 and #76144
doc preview: https://elasticsearch_76520.docs-preview.app.elstc.co/guide/en/elasticsearch/client/java-rest/master/java-rest-high-security-query-api-key.html
Relates: #71023