Fix eclipse compilation of hasValue#76375
Merged
elasticsearchmachine merged 1 commit intoelastic:masterfrom Aug 11, 2021
Merged
Fix eclipse compilation of hasValue#76375elasticsearchmachine merged 1 commit intoelastic:masterfrom
elasticsearchmachine merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
In elastic#76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
pugnascotia
approved these changes
Aug 11, 2021
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: To backport manually run |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Aug 11, 2021
In elastic#76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
Collaborator
💚 Backport successful
|
nik9000
added a commit
that referenced
this pull request
Aug 11, 2021
In #76302 we removed a few warnings in a way that javac was happy with but confused Eclipse. This makes eclipse happy by dropping our overly strict bounds in `AggregationInspectionHelper`. We really weren't using any of the type bounds we'd declared there at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #76302 we removed a few warnings in a way that javac was happy with
but confused Eclipse. This makes eclipse happy by dropping our overly
strict bounds in
AggregationInspectionHelper. We really weren't usingany of the type bounds we'd declared there at all.