QL: Upgrade ANTLR and move it into QL#76358
Merged
elasticsearchmachine merged 3 commits intoelastic:masterfrom Aug 11, 2021
Merged
QL: Upgrade ANTLR and move it into QL#76358elasticsearchmachine merged 3 commits intoelastic:masterfrom
elasticsearchmachine merged 3 commits intoelastic:masterfrom
Conversation
Following elastic#76288, upgrade ANTLR library to benefit from the various improvements made in most recent releases in particular better performance and error messages. Looking at the changelog, since version 4.7.2 most changes in ANTLR seem to have occurred in non-Java targets however this commit upgrades to ANTLR 4.9.2 to benefit from the dependency updates (such as StringTemplate). Additionally move the library into QL to consolidate its use across QL projects. Relates elastic#74448 Fix elastic#76354
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
Member
Author
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
1 similar comment
Member
Author
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
Member
Author
|
@elasticsearchmachine update branch |
Member
Author
|
@elasticmachine update branch |
Collaborator
💚 Backport successful
|
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Aug 11, 2021
* QL: Upgrade ANTLR and move it into QL Following elastic#76288, upgrade ANTLR library to benefit from the various improvements made in most recent releases in particular better performance and error messages. Looking at the changelog, since version 4.7.2 most changes in ANTLR seem to have occurred in non-Java targets however this commit upgrades to ANTLR 4.9.2 to benefit from the dependency updates (such as StringTemplate). Additionally move the library into QL to consolidate its use across QL projects. Relates elastic#74448 Fix elastic#76354 * Fix matching on error message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 12, 2021
* QL: Upgrade ANTLR and move it into QL Following #76288, upgrade ANTLR library to benefit from the various improvements made in most recent releases in particular better performance and error messages. Looking at the changelog, since version 4.7.2 most changes in ANTLR seem to have occurred in non-Java targets however this commit upgrades to ANTLR 4.9.2 to benefit from the dependency updates (such as StringTemplate). Additionally move the library into QL to consolidate its use across QL projects. Relates #74448 Fix #76354 * Fix matching on error message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #76288, upgrade ANTLR library to benefit from the various
improvements made in most recent releases in particular better
performance and error messages.
Looking at the changelog, since version 4.7.2 most changes in ANTLR seem
to have occurred in non-Java targets however this commit upgrades to
ANTLR 4.9.2 to benefit from the dependency updates (such as
StringTemplate).
Additionally move the library into QL to consolidate its use across QL
projects.
Relates #74448
Fix #76354