Skip to content

Resolve system properties in build scripts via provider factory#76199

Merged
breskeby merged 1 commit intoelastic:masterfrom
breskeby:use-systemprop-provider-in-build-scripts
Aug 9, 2021
Merged

Resolve system properties in build scripts via provider factory#76199
breskeby merged 1 commit intoelastic:masterfrom
breskeby:use-systemprop-provider-in-build-scripts

Conversation

@breskeby
Copy link
Copy Markdown
Contributor

@breskeby breskeby commented Aug 5, 2021

This allows tracking system properties used in the build configuration and brings us
one step closer to be gradle configuration cache compliant.

This allows tracking system properties used in the build configuration and brings us
one step closer to be gradle configuration cache compliant.
@breskeby breskeby self-assigned this Aug 5, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0 labels Aug 5, 2021
@breskeby breskeby marked this pull request as ready for review August 5, 2021 20:30
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Copy Markdown
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby added the auto-backport Automatically create backport pull requests when merged label Aug 9, 2021
@breskeby breskeby merged commit b323726 into elastic:master Aug 9, 2021
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
backport --pr 76199

@breskeby breskeby added v7.16.0 and removed v7.15.0 labels Oct 5, 2021
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Oct 5, 2021
…tic#76199)

This allows tracking system properties used in the build configuration and brings us
one step closer to be gradle configuration cache compliant.
elasticsearchmachine pushed a commit that referenced this pull request Oct 5, 2021
* Resolve system properties in build scripts via provider factory (#76199)

This allows tracking system properties used in the build configuration and brings us
one step closer to be gradle configuration cache compliant.

* Fix system property resolution at configuration time (#78669)

This fixes system property resolution when running the build with --configuration-cache

One step closer to make use of configuration cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0-alpha2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants