[Test] Allow trace.id in default thread context.#76089
Merged
ywangd merged 1 commit intoelastic:masterfrom Aug 5, 2021
Merged
Conversation
A new trace.id header is added by elastic#74210. It is handled almost the same way as x-opaque-id. Specifically, it gets passed into default thread context. This means the existing assertion should expect it in addition to x-opaque-id.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
approved these changes
Aug 4, 2021
Contributor
pgomulka
left a comment
There was a problem hiding this comment.
great find. I totally forgot about this.
Did this highlight itself in any tests?
LGTM
Member
Author
No, I noticed it when doing ad-hoc manual testings. |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 5, 2021
A new trace.id header is added by elastic#74210. It is handled almost the same way as x-opaque-id. Specifically, it gets passed into default thread context. This means the existing assertion should expect it in addition to x-opaque-id.
Collaborator
💚 Backport successful
|
ywangd
pushed a commit
that referenced
this pull request
Aug 5, 2021
A new trace.id header is added by #74210. It is handled almost the same way as x-opaque-id. Specifically, it gets passed into default thread context. This means the existing assertion should expect it in addition to x-opaque-id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new trace.id header is added by #74210. It is handled almost the same
way as x-opaque-id. Specifically, it gets passed into default thread
context. This means the existing assertion should expect it in addition
to x-opaque-id.
Relates: #74210