Skip to content

Flip node shutdown feature flag to default to true on snapshot builds#75962

Merged
elasticsearchmachine merged 2 commits intoelastic:masterfrom
dakrone:shutdown-ff-default-true
Aug 2, 2021
Merged

Flip node shutdown feature flag to default to true on snapshot builds#75962
elasticsearchmachine merged 2 commits intoelastic:masterfrom
dakrone:shutdown-ff-default-true

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Aug 2, 2021

It previously defaulted to false. The setting can still only be set to 'true' on a
non-release (snapshot) build of Elasticsearch.

Relates to #70338

It previously defaulted to false. The setting can still only be set to 'true' on a
non-release (snapshot) build of Elasticsearch.

Relates to elastic#70338
@dakrone dakrone added v8.0.0 :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v7.15.0 labels Aug 2, 2021
@dakrone dakrone requested a review from AthenaEryma August 2, 2021 15:15
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Aug 2, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Contributor

@AthenaEryma AthenaEryma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dakrone dakrone added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Aug 2, 2021
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Aug 2, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticsearchmachine elasticsearchmachine merged commit a76ee40 into elastic:master Aug 2, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 2, 2021
…elastic#75962)

* Flip node shutdown feature flag to default to true on snapshot builds

It previously defaulted to false. The setting can still only be set to 'true' on a
non-release (snapshot) build of Elasticsearch.

Relates to elastic#70338

* Handle case where operator privileges are enabled
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
7.x

dakrone added a commit that referenced this pull request Aug 2, 2021
…builds (#75962) (#75980)

Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
Co-authored-by: Lee Hinman <lee@writequit.org>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 3, 2021
…elastic#75962)

* Flip node shutdown feature flag to default to true on snapshot builds

It previously defaulted to false. The setting can still only be set to 'true' on a
non-release (snapshot) build of Elasticsearch.

Relates to elastic#70338

* Handle case where operator privileges are enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown >non-issue Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team v7.15.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants