ILM ClusterStateWaitThresholdBreachTests cycles due to shrunk-shards-allocated#75695
Merged
andreidan merged 1 commit intoelastic:masterfrom Jul 27, 2021
Merged
Conversation
…-allocated` ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step.
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
approved these changes
Jul 26, 2021
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this Andrei
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Jul 27, 2021
…-allocated` (elastic#75695) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step. (cherry picked from commit 3b2973d) Signed-off-by: Andrei Dan <andrei.dan@elastic.co> # Conflicts: # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/ilm/ClusterStateWaitThresholdBreachTests.java
andreidan
added a commit
that referenced
this pull request
Jul 27, 2021
…-allocated` (#75695) (#75729) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step. (cherry picked from commit 3b2973d) Signed-off-by: Andrei Dan <andrei.dan@elastic.co> # Conflicts: # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/ilm/ClusterStateWaitThresholdBreachTests.java
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…-allocated` (elastic#75695) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClusterStateWaitThresholdBreachTests is meant to simulate a shrink
action failure that lasts past the threshold we configured such that ILM
rewinds, deletes an attempted shrunk index and retries (successfully the
2nd time).
We used to simulated this failure by configuring a shrink action with a
number of shards higher than the index number of shards. We're now
adding a step that'll validate against this misconfiguration so we
needed a new way to integration test this shrink action cycle.
This makes the test use a high number of replicas configuration for the
managed index, blocking it in the
shrunk-shards-allocatedstep,instead of the previous failure in the
shrinkstep.Relates to #74219