Unsigned long should accept value with zero fraction#75646
Merged
dnhatn merged 7 commits intoelastic:masterfrom Jul 30, 2021
Merged
Unsigned long should accept value with zero fraction#75646dnhatn merged 7 commits intoelastic:masterfrom
dnhatn merged 7 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
mayya-sharipova
requested changes
Jul 29, 2021
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@dnhatn Thanks for this fix, and sorry for a late reply. The change and the tests overall look great to me, but we should also address a case where a zero decimal comes in a numeric form, as current the following test will fail:
ParsedDocument doc = mapper.parse(source(b -> b.field("field", 100.0)));
assertThat(doc.rootDoc().getFields("field")[0].numericValue().longValue(), equalTo(Long.MIN_VALUE + 100L));
Member
Author
|
Thanks Mayya! I pushed fdf023b. |
Member
Author
|
@elasticmachine update branch |
mayya-sharipova
approved these changes
Jul 30, 2021
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks Nhat, this LGTM
Member
Author
|
@mayya-sharipova Thanks for reviews. |
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 30, 2021
elasticsearchmachine
added a commit
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67565