Skip to content

Address recent percolator failures.#75620

Merged
jpountz merged 2 commits intoelastic:masterfrom
jpountz:fix/percolator_failures
Jul 22, 2021
Merged

Address recent percolator failures.#75620
jpountz merged 2 commits intoelastic:masterfrom
jpountz:fix/percolator_failures

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented Jul 22, 2021

They are due to changes to indices.query.bool.max_clause_count that got pushed
in #75297.

Closes #75591
Closes #75592

@jpountz
Address recent percolator failures.
8df89f4 
They are due to changes to `indices.query.bool.max_clause_count` that got pushed
in elastic#75297.

Closes elastic#75591
Closes elastic#75592
@jpountz jpountz requested a review from romseygeek July 22, 2021 09:02
@jpountz jpountz added :Search Relevance/Percolator Reverse search: find queries that match a document >test Issues or PRs that are addressing/adding tests labels Jul 22, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 22, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jul 22, 2021

Pinging @elastic/es-search (Team:Search)

@romseygeek
Copy link
Copy Markdown
Contributor

romseygeek commented Jul 22, 2021

I wonder if it's worth extracting 4096 into a separate shared static value somewhere, so that if it gets changed again then this will automatically be updated as well?

@jpountz
Copy link
Copy Markdown
Contributor Author

jpountz commented Jul 22, 2021

I did something different that consists of explicitly setting the max number of clauses so that we don't have to rely on the defaults. Would that work for you?

@jpountz
Copy link
Copy Markdown
Contributor Author

jpountz commented Jul 22, 2021

You might want to add ?w=1 to the URL when reviewing to make the diff more readable given indentation changes.

romseygeek
romseygeek approved these changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpountz jpountz merged commit 9dceb86 into elastic:master Jul 22, 2021
@jpountz jpountz deleted the fix/percolator_failures branch July 22, 2021 10:04
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@jpountz @ywangd
Address recent percolator failures. (elastic#75620)
76a4eb3 
They are due to changes to `indices.query.bool.max_clause_count` that got pushed
in elastic#75297.

Closes elastic#75591
Closes elastic#75592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

No one assigned

Labels

:Search Relevance/Percolator Reverse search: find queries that match a document Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] CandidateQueryTests testPercolateSmallAndLargeDocument failing [CI] PercolatorFieldMapperTests testCreateCandidateQuery failing

5 participants

@jpountz @elasticmachine @romseygeek @jakelandis @elasticsearchmachine