Enable compiler warnings in x-pack security#75473
Merged
pugnascotia merged 2 commits intoelastic:masterfrom Jul 21, 2021
Merged
Enable compiler warnings in x-pack security#75473pugnascotia merged 2 commits intoelastic:masterfrom
pugnascotia merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
23 tasks
mark-vieira
approved these changes
Jul 21, 2021
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
FWIW, in homer I specifically introduced a cast() method for this purpose. We might want to consider something similar to avoid having @SuppressWarnings all over the place.
Contributor
Author
|
Backported to |
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40366