[Rest Api Compatibility] Voting config exclusion exception message#75406
Merged
pgomulka merged 1 commit intoelastic:masterfrom Jul 26, 2021
Merged
[Rest Api Compatibility] Voting config exclusion exception message#75406pgomulka merged 1 commit intoelastic:masterfrom
pgomulka merged 1 commit intoelastic:masterfrom
Conversation
the exception message has changed in elastic#55291. This is not covered by rest api compatibility, so no need to return the old message for v7 requests. This commit adds a transformation to allow for the 7.x test to pass with a new exception message relates elastic#51816
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
|
So the previous version of this API accepted a node filter as a path argument. That is, What do you think about that? We could 'just' return an error (and I absolutely think that's defensible). OR, when we receive the parameter, we could inspect it to figure out if it's something we can translate into the current API, and then run it. I'm on the fence about whether I think would be a good path to go down or not. |
joegallo
approved these changes
Jul 26, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…lastic#75406) the exception message has changed in elastic#55291. This is not covered by rest api compatibility, so no need to return the old message for v7 requests. This commit adds a transformation to allow for the 7.x test to pass with a new exception message relates elastic#51816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the exception message has changed in #55291. This is not covered by rest
api compatibility, so no need to return the old message for v7 requests.
This commit adds a transformation to allow for the 7.x test to pass with
a new exception message
relates #51816
gradle check?