Make FeatureFactory tests more resilient#75405
Merged
iverase merged 3 commits intoelastic:masterfrom Jul 20, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
imotov
approved these changes
Jul 19, 2021
| } | ||
| if (i == 0 || posLon != prevLon || posLat != prevLat) { | ||
| // filter out repeated points | ||
| if (numPoints == 0 || posLon != prevLon || posLat != prevLat) { |
Contributor
There was a problem hiding this comment.
Since you are no longer using i, you can probably replace the for loop and remove it completely.
iverase
added a commit
that referenced
this pull request
Jul 20, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
making sure the spatial relationships between the tile and the generated points is honour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature factory tests might fail because they are not taking into account the encoding values of the points in the tile. Therefore points might not have the spatial relationships with the tile the test is assuming. This PR makes the test more resilient by making sure the spatial relationships is honour.
fixes #75325
fixes #75358