Skip to content

[ML] Rename JobNodeLoadDetectorTests to match tested class#75370

Merged
elasticsearchmachine merged 1 commit intoelastic:masterfrom
dimitris-athanasiou:rename-job-node-load-detector-test
Jul 15, 2021
Merged

[ML] Rename JobNodeLoadDetectorTests to match tested class#75370
elasticsearchmachine merged 1 commit intoelastic:masterfrom
dimitris-athanasiou:rename-job-node-load-detector-test

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

@dimitris-athanasiou dimitris-athanasiou commented Jul 15, 2021

Tested class is NodeLoadDetector thus the test class name
should be NodeLoadDetectorTests.

@dimitris-athanasiou
[ML] Rename JobNodeLoadDetectorTests to match tested class
060b6fc 
Tested class is `NodeLoadDetector` thus the test class name
should be `NodeLoadDetectorTests`.
@dimitris-athanasiou dimitris-athanasiou added >refactoring :ml Machine learning v8.0.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged v7.15.0 labels Jul 15, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jul 15, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jul 15, 2021

Pinging @elastic/ml-core (Team:ML)

droberts195
droberts195 approved these changes Jul 15, 2021
View reviewed changes
Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine merged commit 640fd9b into elastic:master Jul 15, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 15, 2021
@dimitris-athanasiou
[ML] Rename JobNodeLoadDetectorTests to match tested class (elastic#7…
ee14d00 
…5370)

Tested class is `NodeLoadDetector` thus the test class name
should be `NodeLoadDetectorTests`.
@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 15, 2021
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 15, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

@dimitris-athanasiou dimitris-athanasiou deleted the rename-job-node-load-detector-test branch July 15, 2021 11:06
dimitris-athanasiou added a commit that referenced this pull request Jul 15, 2021
@elasticsearchmachine @dimitris-athanasiou
[ML] Rename JobNodeLoadDetectorTests to match tested class (#75370) (#…
0a66f74 
…75373)

Tested class is `NodeLoadDetector` thus the test class name
should be `NodeLoadDetectorTests`.

Co-authored-by: Dimitris Athanasiou <dimitris@elastic.co>
masseyke pushed a commit to masseyke/elasticsearch that referenced this pull request Jul 16, 2021
@dimitris-athanasiou @masseyke
[ML] Rename JobNodeLoadDetectorTests to match tested class (elastic#7…
c67fce7 
…5370)

Tested class is `NodeLoadDetector` thus the test class name
should be `NodeLoadDetectorTests`.
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@dimitris-athanasiou @ywangd
[ML] Rename JobNodeLoadDetectorTests to match tested class (elastic#7…
dee3b89 
…5370)

Tested class is `NodeLoadDetector` thus the test class name
should be `NodeLoadDetectorTests`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@droberts195 droberts195 droberts195 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :ml Machine learning >refactoring Team:ML Meta label for the ML team v7.15.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dimitris-athanasiou @elasticmachine @elasticsearchmachine @droberts195 @jakelandis