Make GeoIpDownloaderIT.testInvalidTimestamp more robust#75330
Merged
probakowski merged 3 commits intoelastic:masterfrom Jul 14, 2021
Merged
Make GeoIpDownloaderIT.testInvalidTimestamp more robust#75330probakowski merged 3 commits intoelastic:masterfrom
probakowski merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
approved these changes
Jul 14, 2021
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left one super minor comment
| client().admin().cluster() | ||
| .prepareUpdateSettings() | ||
| .setPersistentSettings(Settings.builder() | ||
| .put("ingest.geoip.database_validity", (String) null)) |
Member
There was a problem hiding this comment.
Minor nit:
Suggested change
| .put("ingest.geoip.database_validity", (String) null)) | |
| .putNull("ingest.geoip.database_validity") |
Contributor
Author
There was a problem hiding this comment.
Nice, I haven't seen that method before, I've update it in other places in this test as well
Contributor
Author
|
@elasticmachine update branch |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 14, 2021
This change adds additional assertion in GeoIpDownloaderIT.testInvalidTimestamp which makes sure that validity checks work both ways (so going out of validity and back) and it should fix race in cleanUp method leading to occasional failures. Closes elastic#75221 Closes elastic#74358
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 14, 2021
This change adds additional assertion in GeoIpDownloaderIT.testInvalidTimestamp which makes sure that validity checks work both ways (so going out of validity and back) and it should fix race in cleanUp method leading to occasional failures. Closes elastic#75221 Closes elastic#74358
Collaborator
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 15, 2021
… (#75353) * Make GeoIpDownloaderIT.testInvalidTimestamp more robust (#75330) This change adds additional assertion in GeoIpDownloaderIT.testInvalidTimestamp which makes sure that validity checks work both ways (so going out of validity and back) and it should fix race in cleanUp method leading to occasional failures. Closes #75221 Closes #74358 * compilation fix Co-authored-by: Przemko Robakowski <przemko.robakowski@elastic.co>
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 15, 2021
#75354) * Make GeoIpDownloaderIT.testInvalidTimestamp more robust (#75330) This change adds additional assertion in GeoIpDownloaderIT.testInvalidTimestamp which makes sure that validity checks work both ways (so going out of validity and back) and it should fix race in cleanUp method leading to occasional failures. Closes #75221 Closes #74358 * compilation fix Co-authored-by: Przemko Robakowski <przemko.robakowski@elastic.co>
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
This change adds additional assertion in GeoIpDownloaderIT.testInvalidTimestamp which makes sure that validity checks work both ways (so going out of validity and back) and it should fix race in cleanUp method leading to occasional failures. Closes elastic#75221 Closes elastic#74358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds additional assertion in
GeoIpDownloaderIT.testInvalidTimestampwhich makes sure that validity checks work both ways (so going out of validity and back) and it should fix race incleanUpmethod leading to occasional failures.Closes #75221
Closes #74358