Loosen checks in REST test for PIT slicing#75261
Merged
jtibshirani merged 1 commit intoelastic:masterfrom Jul 14, 2021
Merged
Conversation
Since the index may have more than one shard, we can't always predict how many documents will fall in each slice. This PR simply removes the checks, since we already test the slicing logic extensively in an integration test. The REST test is now just a sanity check for the API.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@jtibshirani This LGTM, another alternative could be to explicitly define number of shards, but this also LGTM
Contributor
Author
|
Thanks @mayya-sharipova for reviewing. This felt like the best option to me, as I wanted to keep a variable number of shards for the other tests in this suite and we already check the slicing logic deeply in other tests. |
mayya-sharipova
approved these changes
Jul 14, 2021
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
Since the index may have more than one shard, we can't always predict how many documents will fall in each slice. This PR simply removes the checks, since we already test the slicing logic extensively in an integration test. The REST test is now just a sanity check for the API. Fixes elastic#75212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the index may have more than one shard, we can't always predict how many
documents will fall in each slice. This PR simply removes the checks, since we
already test the slicing logic extensively in an integration test. The REST test
is now just a sanity check for the API.
Fixes #75212.