Refactor SimpleFeatureFactory so it has no external dependencies#75232
Merged
iverase merged 3 commits intoelastic:masterfrom Jul 14, 2021
Merged
Refactor SimpleFeatureFactory so it has no external dependencies#75232iverase merged 3 commits intoelastic:masterfrom
iverase merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
imotov
suggested changes
Jul 12, 2021
Contributor
imotov
left a comment
There was a problem hiding this comment.
I would be more comfortable if it didn't copy code (even if it is one function) without attribution.
Contributor
Author
|
Right, I think it was a mistake to copy those methods as we just need to write integers using vints. I modified the code so we are suing a |
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…stic#75232) SimpleFeatureFactory has no external dependencies now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleFeatureFactory can generate vector tile features of simple geometries like points and rectangles. This PR refactor that class so it does not have external dependencies, e.g it contains the methods to serialise the feature into a byte array. This makes possible to maybe move this class to server.
This PR adds more test to the feature factory implementation,