Skip to content

[Rest Api Compatibility] Allow transforming warnings per test#75187

Merged
pgomulka merged 6 commits intoelastic:masterfrom
pgomulka:compat/warnings_per_test
Jul 15, 2021
Merged

[Rest Api Compatibility] Allow transforming warnings per test#75187
pgomulka merged 6 commits intoelastic:masterfrom
pgomulka:compat/warnings_per_test

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Jul 9, 2021

Warning related transformations missed the possibility to apply per single test only.
Also a warning changed in #67158 for indices.close so this PR also applies the transformation for 7.x test

relates #51816

@pgomulka pgomulka changed the title draft for warnigs per test [Rest Api Compatibility] Allow transforming warnings per test Jul 13, 2021
@pgomulka pgomulka marked this pull request as ready for review July 13, 2021 13:26
@pgomulka pgomulka self-assigned this Jul 13, 2021
@pgomulka pgomulka added the >test Issues or PRs that are addressing/adding tests label Jul 13, 2021
@pgomulka
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@pgomulka pgomulka requested review from jakelandis and joegallo July 14, 2021 14:25
Copy link
Copy Markdown
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


/**
* Adds one or more allowed regular expression warnings
* @param allowedWarningsRegex the regex warning(s) to add
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: javadoc for testName

@pgomulka
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@pgomulka pgomulka merged commit 2320a38 into elastic:master Jul 15, 2021
masseyke pushed a commit to masseyke/elasticsearch that referenced this pull request Jul 16, 2021
…c#75187)

Warning related transformations missed the possibility to apply per single test only.
Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test

relates elastic#51816
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
…c#75187)

Warning related transformations missed the possibility to apply per single test only.
Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test

relates elastic#51816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants