Add null check for shard stats to data tier telemetry#75185
Merged
elasticsearchmachine merged 2 commits intoelastic:masterfrom Jul 15, 2021
Merged
Add null check for shard stats to data tier telemetry#75185elasticsearchmachine merged 2 commits intoelastic:masterfrom
elasticsearchmachine merged 2 commits intoelastic:masterfrom
Conversation
This adds a null check, as `getShardStats(index)` may return null.
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
jbaiera
approved these changes
Jul 15, 2021
Member
jbaiera
left a comment
There was a problem hiding this comment.
LGTM
Question for myself though: in which cases might the shard stats not be present?
Member
Author
|
@elasticmachine update branch |
Member
Author
Honestly I am not quite sure yet (which is why I did not originally add a null check). I will try to investigate to see why. |
Collaborator
💔 Backport failed
To backport manually run: |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 15, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 15, 2021
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a null check, as
getShardStats(index)may return null.