Geometry formatters should be applied to the full array#75177
Merged
iverase merged 7 commits intoelastic:masterfrom Jul 14, 2021
Merged
Geometry formatters should be applied to the full array#75177iverase merged 7 commits intoelastic:masterfrom
iverase merged 7 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Contributor
Author
|
@romseygeek do you mind having a look, I a pretty happy with the PR now. |
romseygeek
approved these changes
Jul 14, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. We already have tests that check that an individual badly-formatted geometry doesn't prevent other geometries from the same field being indexed if ignore_malformed is set to true I think? So if CI is happy then so am I :)
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
Changes the way we fetch values from source in geo fields so we can format all data in one go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when formatting a geometry object, we applyy formatting to each element of an array individually. For many cases that is enough but we oversee that some formatters (eg. vector tiles) needs to be applied to the whole array at once. At the end of the day an array of geometries is equivalent to a Geometry collection.
Therefore this PR changes the way we process formatters so they are apply to a List of Geometries.