Fix BanFailureLoggingTests#75171
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Jul 13, 2021
Merged
Conversation
Today both `BanFailureLoggingTests` fail to remove the ban and report this in the logs. `testLogsAtDebugOnDisconnectionDuringBan` does not wait for this message to be logged, so the logging might happen concurrently with the logger being stopped and removed, resulting in a `Attempted to append to non-started appender mock` failure. This commit ensures that both test cases wait for the expected removal failure message to be logged. Closes elastic#75129
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
@elasticmachine please run elasticsearch-ci/part-1 |
DaveCTurner
added a commit
that referenced
this pull request
Jul 13, 2021
Today both `BanFailureLoggingTests` fail to remove the ban and report this in the logs. `testLogsAtDebugOnDisconnectionDuringBan` does not wait for this message to be logged, so the logging might happen concurrently with the logger being stopped and removed, resulting in a `Attempted to append to non-started appender mock` failure. This commit ensures that both test cases wait for the expected removal failure message to be logged. Closes #75129
DaveCTurner
added a commit
that referenced
this pull request
Jul 13, 2021
Today both `BanFailureLoggingTests` fail to remove the ban and report this in the logs. `testLogsAtDebugOnDisconnectionDuringBan` does not wait for this message to be logged, so the logging might happen concurrently with the logger being stopped and removed, resulting in a `Attempted to append to non-started appender mock` failure. This commit ensures that both test cases wait for the expected removal failure message to be logged. Closes #75129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today both
BanFailureLoggingTestsfail to remove the ban and reportthis in the logs.
testLogsAtDebugOnDisconnectionDuringBandoes notwait for this message to be logged, so the logging might happen
concurrently with the logger being stopped and removed, resulting in a
Attempted to append to non-started appender mockfailure.This commit ensures that both test cases wait for the expected removal
failure message to be logged.
Closes #75129