Improve stability of GeoIpDownloaderIT test suite.#74558
Merged
probakowski merged 1 commit intoelastic:masterfrom Jul 9, 2021
Merged
Conversation
Adjust GeoIpDownloaderIT test suit to wait for managed databases files to be removed after each test. After each test geoip downloader is disabled, which should eventually remove the managed geoip database files. This happens in the background. However a new test starts that assumes that the builtin databases are used then that test can fail, because expected assertions will fail. The changes in this commit should address this. Closes elastic#74358
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 9, 2021
Adjust GeoIpDownloaderIT test suit to wait for managed databases files to be removed after each test. After each test geoip downloader is disabled, which should eventually remove the managed geoip database files. This happens in the background. However a new test starts that assumes that the builtin databases are used then that test can fail, because expected assertions will fail. The changes in this commit should address this. Closes elastic#74358
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 9, 2021
Adjust GeoIpDownloaderIT test suit to wait for managed databases files to be removed after each test. After each test geoip downloader is disabled, which should eventually remove the managed geoip database files. This happens in the background. However a new test starts that assumes that the builtin databases are used then that test can fail, because expected assertions will fail. The changes in this commit should address this. Closes elastic#74358
Collaborator
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 16, 2021
Backport elastic#74558 to 7.17 branch. Adjust GeoIpDownloaderIT test suit to wait for managed databases files to be removed after each test. After each test geoip downloader is disabled, which should eventually remove the managed geoip database files. This happens in the background. However a new test starts that assumes that the builtin databases are used then that test can fail, because expected assertions will fail. The changes in this commit should address this. Closes elastic#74358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust GeoIpDownloaderIT test suit to wait for managed databases files
to be removed after each test.
After each test geoip downloader is disabled, which should eventually
remove the managed geoip database files. This happens in the background.
However a new test starts that assumes that the builtin databases are used
then that test can fail, because expected assertions will fail. The changes
in this commit should address this.
Closes #74358